feature: allow deactivating of scheduled tasks #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
reviewed
Feb 28, 2025
There was a problem hiding this comment.
PR Overview
This pull request introduces a feature to deactivate scheduled tasks in the frosh-tools module. It adds a new frontend method to trigger task deactivation, integrates an API call for deactivation, and patches the UI with appropriate notification messages.
Reviewed Changes
| File | Description |
|---|---|
| src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-scheduled/index.js | Added the deactivateTask method to handle deactivation and update UI notifications. |
| src/Resources/app/administration/src/api/frosh-tools.js | Introduced a new API method to call the backend deactivation endpoint. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-scheduled/index.js:145
- Consider checking if e.response is defined (for example, using optional chaining: e.response?.data) to avoid potential runtime errors when the error object does not include a response.
this.taskError = e.response.data;
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to deactivate scheduled tasks in the
frosh-toolsmodule. The changes include adding a new endpoint to the backend, updating the API service, and modifying the frontend to support this new functionality.Backend changes:
src/Controller/ScheduledTaskController.php: Added a new route and methoddeactivateTaskto handle the deactivation of scheduled tasks.API service changes:
src/Resources/app/administration/src/api/frosh-tools.js: Added a new methoddeactivateScheduledTaskto call the new backend endpoint for deactivating scheduled tasks.Frontend changes:
src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-scheduled/index.js: Added a new methoddeactivateTaskto handle the deactivation process and update the UI accordingly.src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-scheduled/template.twig: Added a new context menu item to trigger the deactivation of a scheduled task.Localization changes:
src/Resources/app/administration/src/module/frosh-tools/snippet/de-DE.json: Added new German translations for the deactivation process messages.src/Resources/app/administration/src/module/frosh-tools/snippet/en-GB.json: Added new English translations for the deactivation process messages.